-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: strip debug symbols #1177
Conversation
Stripping the symbols for the release build drops binary size currently by 20% and the plugin binaries by up to 50%. Alternative: Keep the debug symbols also on releases
What does this mean in total size? The binary is currently 16MB.
|
The plugins take:
The
Not yet, that is certainly planned.` For now you could load a layout without specifying plugins: This is a layout that omits the loading of plugins:
|
I'm 100% on board with merging this! I've been warned off of some cutting-edge features by @imsnif in the past (as they can break for people who haven't updated their Rust in a while), but I'm personally up for merging whenever others are comfortable! |
How do you mean? Will people need a higher version of rust than is in eg. apt? |
I've not actually checked if it breaks older versions, so it might just be ignored, but it's a feature of the latest stable – 1.59.0 (Blog) |
They will "need" a higher version of |
@imsnif I've confirmed it breaks for at least 1.57 which was the version on my Ubuntu docker image Maybe we just offer to migrate all of our Ubuntu / Debian users to Arch? 😉 |
Best solution |
This is the update policy of
|
Needed for cargos strip-debug feature
Out of curiosity, why do Panic reports still include line numbers? |
Yes, the panic unwind is not yet really configurable on rust, especially stable rust. |
Stripping the symbols for the release build drops binary size
currently by 20% and the plugin binaries by up to 50%.
Alternative: Keep the debug symbols also on releases